Both approaches have pros and cons. Storing your .photoslibrary file directly on the NAS has the advantage that there's not much you'll need to do. You can make backups of that file via NAS software ...